fix(linter): handle re-exporting of type correctly in import/no-cycle (#10606)

ulrichstark · web-flow · commit 39adefe39cd4 · 2025-04-24T19:25:58.000-04:00
Handle re-exporting of type correctly in import/no-cycle lint rule. Added one passing test (ignoreTypes = default/true) and one failing test (ignoreTypes = false). Closes #10547
diff --git a/crates/oxc_linter/fixtures/import/cycles/typescript/ts-types-re-exporting-type.ts b/crates/oxc_linter/fixtures/import/cycles/typescript/ts-types-re-exporting-type.ts
@@ -0,0 +1,2 @@
+// @ts-ignore
+export type { foo } from "../depth-zero";
diff --git a/crates/oxc_linter/src/rules/import/no_cycle.rs b/crates/oxc_linter/src/rules/import/no_cycle.rs
@@ -142,8 +142,21 @@ impl Rule for NoCycle {
                         .iter()
                         .filter(|entry| entry.module_request.name() == key)
                         .collect::<Vec<_>>();
-                    if !import_entries.is_empty()
+
+                    let indirect_export_entries = parent
+                        .indirect_export_entries
+                        .iter()
+                        .filter(|entry| {
+                            entry
+                                .module_request
+                                .as_ref()
+                                .is_some_and(|module_request| module_request.name() == key)
+                        })
+                        .collect::<Vec<_>>();
+
+                    if (!import_entries.is_empty() || !indirect_export_entries.is_empty())
                         && import_entries.iter().all(|entry| entry.is_type)
+                        && indirect_export_entries.iter().all(|entry| entry.is_type)
                     {
                         return false;
                     }
@@ -257,6 +270,7 @@ fn test() {
         // (r#"import { bar } from "./flow-types-only-importing-type""#, None),
         // (r#"import { bar } from "./flow-types-only-importing-multiple-types""#, None),
         // (r#"import { bar } from "./flow-typeof""#, None),
+        (r#"import { foo } from "./typescript/ts-types-re-exporting-type";"#, None),
     ];
 
     let fail = vec![
@@ -361,6 +375,10 @@ fn test() {
             r#"import { foo } from "./typescript/ts-types-some-type-imports";"#,
             Some(json!([{"ignoreTypes":true}])),
         ),
+        (
+            r#"import { foo } from "./typescript/ts-types-re-exporting-type";"#,
+            Some(json!([{"ignoreTypes":false}])),
+        ),
     ];
 
     Tester::new(NoCycle::NAME, NoCycle::PLUGIN, pass, fail)
diff --git a/crates/oxc_linter/src/snapshots/import_no_cycle.snap b/crates/oxc_linter/src/snapshots/import_no_cycle.snap
@@ -270,3 +270,12 @@ source: crates/oxc_linter/src/tester.rs
   help: These paths form a cycle:
         -> ./typescript/ts-types-some-type-imports - fixtures/import/cycles/typescript/ts-types-some-type-imports.ts
         -> ../depth-zero - fixtures/import/cycles/depth-zero.js
+
+  &#9888; eslint-plugin-import(no-cycle): Dependency cycle detected
+   &#9581;&#9472;[cycles/depth-zero.js:1:21]
+ 1 &#9474; import { foo } from "./typescript/ts-types-re-exporting-type";
+   &middot;                     &#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;&#9472;
+   &#9584;&#9472;&#9472;&#9472;&#9472;
+  help: These paths form a cycle:
+        -> ./typescript/ts-types-re-exporting-type - fixtures/import/cycles/typescript/ts-types-re-exporting-type.ts
+        -> ../depth-zero - fixtures/import/cycles/depth-zero.js

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// @ts-ignore`
	`2`	`+export type { foo } from "../depth-zero";`
-Original file line number
+Diff line change
   help: These paths form a cycle:
         -> ./typescript/ts-types-some-type-imports - fixtures/import/cycles/typescript/ts-types-some-type-imports.ts
         -> ../depth-zero - fixtures/import/cycles/depth-zero.js
++
 +  ⚠ eslint-plugin-import(no-cycle): Dependency cycle detected
 +   ╭─[cycles/depth-zero.js:1:21]
 + 1 │ import { foo } from "./typescript/ts-types-re-exporting-type";
 +   ·                     ─────────────────────────────────────────
 +   ╰────
 +  help: These paths form a cycle:
 +        -> ./typescript/ts-types-re-exporting-type - fixtures/import/cycles/typescript/ts-types-re-exporting-type.ts
 +        -> ../depth-zero - fixtures/import/cycles/depth-zero.js