fix(linter): false positive in react/exhaustive-deps (#11438)

camc314 · camc314 · commit 11d45231afb2 · 2025-06-03T09:06:35.000Z
fixes #11433
diff --git a/crates/oxc_linter/src/rules/react/exhaustive_deps.rs b/crates/oxc_linter/src/rules/react/exhaustive_deps.rs
@@ -504,7 +504,13 @@ impl Rule for ExhaustiveDeps {
                 return false;
             }
 
-            if !is_identifier_a_dependency(dep.name, dep.reference_id, ctx, component_scope_id) {
+            if !is_identifier_a_dependency(
+                dep.name,
+                dep.reference_id,
+                dep.span,
+                ctx,
+                component_scope_id,
+            ) {
                 return false;
             }
             true
@@ -779,6 +785,7 @@ fn concat_members<'a, 'b>(
 fn is_identifier_a_dependency<'a>(
     ident_name: Atom<'a>,
     ident_reference_id: ReferenceId,
+    ident_span: Span,
     ctx: &'_ LintContext<'a>,
     component_scope_id: ScopeId,
 ) -> bool {
@@ -835,6 +842,17 @@ fn is_identifier_a_dependency<'a>(
         return false;
     }
 
+    // Using a declaration recursively is ok
+    // ```tsx
+    // function MyComponent() {
+    //     const recursive = useCallback((n: number): number => (n <= 0 ? 0 : n + recursive(n - 1)), []);
+    //     return recursive
+    // }
+    // ```
+    if declaration.span().contains_inclusive(ident_span) {
+        return false;
+    }
+
     true
 }
 
@@ -969,7 +987,13 @@ fn is_function_stable<'a, 'b>(
 
     deps.iter().all(|dep| {
         dep.symbol_id.zip(function_symbol_id).is_none_or(|(l, r)| l != r)
-            && !is_identifier_a_dependency(dep.name, dep.reference_id, ctx, component_scope_id)
+            && !is_identifier_a_dependency(
+                dep.name,
+                dep.reference_id,
+                dep.span,
+                ctx,
+                component_scope_id,
+            )
     })
 }
 
@@ -2159,6 +2183,7 @@ fn test() {
   return null;
 }
 "#,
+        r"function MyComponent() { const recursive = useCallback((n: number): number => (n <= 0 ? 0 : n + recursive(n - 1)), []); return recursive }",
     ];
 
     let fail = vec![
