fix(linter): false positive in react/exhaustive-deps with default formal parameter (#11395)

camc314 · camc314 · commit 0d240e4935ec · 2025-05-30T14:44:32.000Z
fixes #11396
diff --git a/crates/oxc_linter/src/rules/react/exhaustive_deps.rs b/crates/oxc_linter/src/rules/react/exhaustive_deps.rs
@@ -7,9 +7,9 @@ use oxc_ast::{
     AstKind, AstType,
     ast::{
         Argument, ArrayExpressionElement, ArrowFunctionExpression, BindingPatternKind,
-        CallExpression, ChainElement, Expression, Function, FunctionBody, IdentifierReference,
-        MemberExpression, StaticMemberExpression, TSTypeAnnotation, TSTypeParameter,
-        TSTypeReference, VariableDeclarationKind,
+        CallExpression, ChainElement, Expression, FormalParameters, Function, FunctionBody,
+        IdentifierReference, MemberExpression, StaticMemberExpression, TSTypeAnnotation,
+        TSTypeParameter, TSTypeReference, VariableDeclarationKind,
     },
     match_expression,
 };
@@ -373,6 +373,8 @@ impl Rule for ExhaustiveDeps {
         let (found_dependencies, refs_inside_cleanups) = {
             let mut found_dependencies = ExhaustiveDepsVisitor::new(ctx.semantic());
 
+            found_dependencies.visit_formal_parameters(callback_node.parameters());
+
             if let Some(function_body) = callback_node.body() {
                 found_dependencies.visit_function_body(function_body);
             }
@@ -631,6 +633,13 @@ impl<'a> CallbackNode<'a> {
         }
     }
 
+    fn parameters(&self) -> &FormalParameters<'a> {
+        match self {
+            CallbackNode::Function(func) => &func.params,
+            CallbackNode::ArrowFunction(func) => &func.params,
+        }
+    }
+
     fn body(&self) -> Option<&FunctionBody<'a>> {
         match self {
             CallbackNode::Function(func) => func.body.as_deref(),
@@ -2139,6 +2148,17 @@ fn test() {
                };
            }, []);
         }",
+        r#"function X() {
+  const defaultParam1 = "";
+  const myFunction = useCallback(
+    (param1 = defaultParam1, param2) => {
+    },
+    [defaultParam1]
+  );
+
+  return null;
+}
+"#,
     ];
 
     let fail = vec![
