-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat: support extends configuration from oxlint config content #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support extends configuration from oxlint config content #419
Conversation
|
Thanks for helping with the plugin ❤️
The first 3 parts can be done easily. The others tasks, I do not expect to be resolved by you. I can follow up after that ❤️ |
|
Hey @Sysix 😄 I’ve updated the implementation based on your feedback:
Some Implementation Details:
I tried to cover all the points — even the ones you said weren’t strictly necessary. If more changes are needed, feel free to guide me 😃. |
|
Thank you ❤️ All extends should be relative to the provided config file. Someone can use Let me recheck, if something is done with Extending a file without a "plugins" key will probably extend the default plugins. If you want, you can tackle the problems down. Thank you already for the work 🫶 |
|
@Sysix I tackled the problems down |
|
@yunarch I updated the branch and simplified some bits. Created a Please recheck if I did not break something :) |
|
@Sysix Everything looks good |
|
Thank you for the work ❤️ |
Description
This PR introduces an initial implementation to support the extends property in configuration files and follow the full chain of extended files.
Currently, it handles merging of only the following fields:
rulespluginsoverridesThese are the only fields currently supported by oxlint, and it doesn’t appear necessary to support others at this stage.
Fixes #386