Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.13.7
Choose a base ref
...
head repository: npm/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.14.0
Choose a head ref
  • 20 commits
  • 46 files changed
  • 10 contributors

Commits on Feb 25, 2020

  1. fix: check npm.config before accessing its members 

    Sometimes, `npm.config` can be missing entirely, but there are several
places where `npm.config.foo` is accessed blindly, resulting in these
kinds of errors and stack traces:

TypeError: Cannot read property 'get' of undefined
    at errorMessage (.../lib/utils/error-message.js:38:39)
    ...

TypeError: Cannot read property 'loaded' of undefined
    at exit (.../lib/utils/error-handler.js:97:27)
    ...

LBYL by checking `npm.config` first. Addresses a small part of #502.

PR-URL: #508
Credit: @
Close: #508
Reviewed-by: @darcy Clarke
    @kgetz-arista @darcyclarke
    kgetz-arista authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    55916b1 View commit details
    Browse the repository at this point in the history

  2. First take on breaking out the lifecycle hooks.

    @seanhealy @darcyclarke
    seanhealy authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    fbb5f0e View commit details
    Browse the repository at this point in the history

  3. docs: updated scripts docs in using-npm section 

    - A continuation of @seanhealy's work

PR-URL: #729
Credit: @
Close: #729
Reviewed-by: @darcy Clarke
    @darcyclarke
    Michael Perrotte authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    284c1c0 View commit details
    Browse the repository at this point in the history

  4. access: grant is ok with non-scoped 

    PR-URL: #733
Credit: @
Close: #733
Reviewed-by: @darcy Clarke
    @netanelgilad @darcyclarke
    netanelgilad authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    7d0cd65 View commit details
    Browse the repository at this point in the history

  5. feat: added script to update dist-tags 

    PR-URL: #736
Credit: @
Close: #736
Reviewed-by: @darcy Clarke
    @darcyclarke
    Michael Perrotte authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    85c7963 View commit details
    Browse the repository at this point in the history

  6. Correct typo 

    PR-URL: #787
Credit: @
Close: #787
Reviewed-by: @darcy Clarke
    @dnicolson @darcyclarke
    dnicolson authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    1c27283 View commit details
    Browse the repository at this point in the history

  7. updated script to say postinstall to show intention 

    PR-URL: #936
Credit: @
Close: #936
Reviewed-by: @darcy Clarke
    @ajaymathur @darcyclarke
    ajaymathur authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    f6ff417 View commit details
    Browse the repository at this point in the history

  8. Update npm-publish.md 

    Fixed wrong links in See also section

PR-URL: #939
Credit: @
Close: #939
Reviewed-by: @darcy Clarke
    @vit100 @darcyclarke
    vit100 authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    373224b View commit details
    Browse the repository at this point in the history

  9. fund: support multiple funding sources 

    See npm/rfcs#68

PR-URL: #731
Credit: @
Close: #731
Reviewed-by: @darcy Clarke
    @ljharb @darcyclarke
    ljharb authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    30f1708 View commit details
    Browse the repository at this point in the history

  10. allow new majors of node to be automatically considered supported 

    PR-URL: #697
Credit: @ljharb
Close: #697
Reviewed-by: @isaacs
    @ljharb @darcyclarke
    ljharb authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    0769c5b View commit details
    Browse the repository at this point in the history

  11. Use a package.json engines field to specify support 

    That is what the `engines` in package.json is for, after all.

PR-URL: #945
Credit: @isaacs
Close: #945
Reviewed-by: @darcyclarke
    @isaacs @darcyclarke
    isaacs authored and darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    28c3d40 View commit details
    Browse the repository at this point in the history

  12. fix: supported version implementation update linting & test coverage

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    d383adb View commit details
    Browse the repository at this point in the history

  13. [email protected]

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    a6789b1 View commit details
    Browse the repository at this point in the history

  14. [email protected]

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    89ce4cc View commit details
    Browse the repository at this point in the history

  15. [email protected]

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    ea0ff56 View commit details
    Browse the repository at this point in the history

  16. [email protected]

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    3d48893 View commit details
    Browse the repository at this point in the history

  17. [email protected]

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    7602146 View commit details
    Browse the repository at this point in the history

  18. docs: changelog for 6.14.0

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    31ca3a8 View commit details
    Browse the repository at this point in the history

  19. update AUTHORS

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    e01f338 View commit details
    Browse the repository at this point in the history

  20. 6.14.0

    @darcyclarke
    darcyclarke committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    83293c4 View commit details
    Browse the repository at this point in the history
Loading