Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(n8n Form Node): Trigger page stack in waiting if error in workflow #11671

Merged

Conversation

michael-radency
Copy link
Contributor

Summary

Render error page if error in workflow

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/NODE-1991/form-node-waits-forever-on-exec-error

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/cli/src/response-helper.ts 0.00% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ShireenMissi ShireenMissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ShireenMissi ShireenMissi added the tests-needed This PR needs additional tests label Nov 13, 2024
Copy link

cypress bot commented Nov 13, 2024

n8n    Run #7842

Run Properties:  status check passed Passed #7842  •  git commit 630874d3ab: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Project n8n
Branch Review node-1991-form-node-waits-forever-on-exec-error
Run status status check passed Passed #7842
Run duration 04m 16s
Commit git commit 630874d3ab: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 michael-radency 🗃️ e2e/*
Committer Michael Kret
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@ShireenMissi ShireenMissi merged commit 94b5873 into master Nov 13, 2024
35 checks passed
@ShireenMissi ShireenMissi deleted the node-1991-form-node-waits-forever-on-exec-error branch November 13, 2024 11:08
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released tests-needed This PR needs additional tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants