fix(core): Handle websocket connection error more gracefully in task runners #11635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
tomi
reviewed
Nov 8, 2024
| @@ -88,6 +88,18 @@ export abstract class TaskRunner { | |||
| }, | |||
| maxPayload: opts.maxPayloadSize, | |||
| }); | |||
|
|
|||
| this.ws.addEventListener('error', (error) => { | |||
| if (error.message?.includes('ECONNREFUSED') || error.message?.includes('ENOTFOUND')) { | |||
There was a problem hiding this comment.
We could check error.code instead of using message
There was a problem hiding this comment.
This error has no code it seems: https://share.cleanshot.com/23B8xxCy
There was a problem hiding this comment.
Oh right, sorry, I meant error.error.code. And maybe rename error to event so it's event.error instead of error.error
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
cat-318
|
| Run status |
|
| Run duration | 04m 23s |
| Commit |
|
| Committer | Iván Ovejero |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
466
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/n8n/issue/CAT-318