Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Fix default workflow settings #11632

Merged
merged 2 commits into from
Nov 8, 2024
Merged

fix(editor): Fix default workflow settings #11632

merged 2 commits into from
Nov 8, 2024

Conversation

cstuncsik
Copy link
Contributor

@cstuncsik cstuncsik commented Nov 7, 2024 •
edited
Loading

Summary

After the composition API refactor, the component showed incorrect default values for execution data saving dropdowns

Related Linear tickets, Github issues, and Community forum posts

PAY-2212

Review / Merge checklist

  • PR title and summary are descriptive.
  • Tests included.
  • PR Labeled with release/backport

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 7, 2024
@netroy netroy added the release/backport Changes that need to be backported to older releases. label Nov 7, 2024
@cstuncsik cstuncsik marked this pull request as ready for review November 8, 2024 12:55
@cstuncsik cstuncsik requested a review from netroy November 8, 2024 12:56
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

netroy
netroy approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Works as expected 🎉

@cypress Cypress
Copy link

cypress bot commented Nov 8, 2024

n8n    Run #7796

Run Properties:  status check passed Passed #7796  •  git commit 95a53e9bd5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Project n8n
Branch Review pay-2212-fix-default-workflow-settings
Run status status check passed Passed #7796
Run duration 04m 27s
Commit git commit 95a53e9bd5: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 cstuncsik 🗃️ e2e/*
Committer Csaba Tuncsik
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 465
View all changes introduced in this branch ↗︎

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

✅ All Cypress E2E specs passed

@netroy netroy merged commit 658568e into master Nov 8, 2024
39 checks passed
@netroy netroy deleted the pay-2212-fix-default-workflow-settings branch November 8, 2024 14:48
@despairblue despairblue mentioned this pull request Nov 11, 2024
Closed
OlegIvaniv pushed a commit that referenced this pull request Nov 12, 2024
@cstuncsik @OlegIvaniv
fix(editor): Fix default workflow settings (#11632)
0aa80ef
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netroy netroy netroy approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstuncsik @janober @netroy