Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Add stickies to node insert position conflict check allowlist #11624

Merged

Conversation

alexgrozav
Copy link
Member

Summary

image

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/CAT-319/node-positions-change-when-switching-to-new-canvas

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@alexgrozav alexgrozav self-assigned this Nov 7, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

cypress bot commented Nov 7, 2024

n8n    Run #7777

Run Properties:  status check passed Passed #7777  •  git commit 142bacd34c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Project n8n
Branch Review cat-319-node-positions-change-when-switching-to-new-canvas
Run status status check passed Passed #7777
Run duration 04m 30s
Commit git commit 142bacd34c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/*
Committer Alex Grozav
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 465
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ All Cypress E2E specs passed

@alexgrozav alexgrozav merged commit fc39e3c into master Nov 7, 2024
35 checks passed
@alexgrozav alexgrozav deleted the cat-319-node-positions-change-when-switching-to-new-canvas branch November 7, 2024 14:20
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants