Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Show only error title and 'Open errored node' button; hide 'Ask Assistant' in root for sub-node errors #11573

Merged

Conversation

igatanasov
Copy link
Contributor

@igatanasov igatanasov commented Nov 5, 2024

Summary

Show only error title and 'Open errored node' button; hide 'Ask Assistant' in root for sub-node errors

Related Linear tickets, Github issues, and Community forum posts


Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@igatanasov igatanasov force-pushed the ado-2730-feature-change-error-display-of-sub-node branch from 71de1b2 to 170ce64 Compare November 5, 2024 21:25
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/editor-ui/src/components/Error/NodeErrorView.vue 95.45% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@igatanasov igatanasov force-pushed the ado-2730-feature-change-error-display-of-sub-node branch from 799519b to 0374b82 Compare November 6, 2024 14:36
@igatanasov igatanasov requested a review from mutdmour November 6, 2024 21:27
Copy link
Contributor

@MiloradFilipovic MiloradFilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Left a minor comment for the code but good to go without it.

Copy link

cypress bot commented Nov 7, 2024

n8n    Run #7753

Run Properties:  status check passed Passed #7753  •  git commit a003890fc3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Project n8n
Branch Review ado-2730-feature-change-error-display-of-sub-node
Run status status check passed Passed #7753
Run duration 04m 19s
Commit git commit a003890fc3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
Committer Ivan Atanasov
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 460
View all changes introduced in this branch ↗︎

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ All Cypress E2E specs passed

@igatanasov igatanasov merged commit 8cba100 into master Nov 7, 2024
47 checks passed
@igatanasov igatanasov deleted the ado-2730-feature-change-error-display-of-sub-node branch November 7, 2024 09:14
OlegIvaniv pushed a commit that referenced this pull request Nov 12, 2024
…de 'Ask Assistant' in root for sub-node errors (#11573)
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
@janober
Copy link
Member

janober commented Nov 13, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants