-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Show only error title and 'Open errored node' button; hide 'Ask Assistant' in root for sub-node errors #11573
fix(editor): Show only error title and 'Open errored node' button; hide 'Ask Assistant' in root for sub-node errors #11573
Conversation
…Assistant' in root for sub-node errors
71de1b2
to
170ce64
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
799519b
to
0374b82
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected. Left a minor comment for the code but good to go without it.
n8n Run #7753
Run Properties:
|
Project |
n8n
|
Branch Review |
ado-2730-feature-change-error-display-of-sub-node
|
Run status |
Passed #7753
|
Run duration | 04m 19s |
Commit |
a003890fc3: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 igatanasov 🗃️ e2e/*
|
Committer | Ivan Atanasov |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
2
|
Skipped |
0
|
Passing |
460
|
View all changes introduced in this branch ↗︎ |
✅ All Cypress E2E specs passed |
…de 'Ask Assistant' in root for sub-node errors (#11573)
Got released with |
Summary
Show only error title and 'Open errored node' button; hide 'Ask Assistant' in root for sub-node errors
Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)