GODRIVER-2891 Add documentation for log levels #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blink1073
requested changes
Jul 7, 2023
Co-authored-by: Steven Silvester <[email protected]>
matthewdale
approved these changes
Jul 19, 2023
Co-authored-by: Matt Dale <[email protected]>
Co-authored-by: Matt Dale <[email protected]>
qingyang-hu
pushed a commit
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: Matt Dale <[email protected]>
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: Matt Dale <[email protected]>
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: Matt Dale <[email protected]>
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 1, 2023
Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: Matt Dale <[email protected]>
prestonvasquez
added a commit
to prestonvasquez/mongo-go-driver
that referenced
this pull request
Aug 2, 2023
Co-authored-by: Steven Silvester <[email protected]> Co-authored-by: Matt Dale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2891
Summary
Add documentation for the level mappings propagated by the internal library to the user-defined LogSink. Clarify that the level returned is not intended to be 1-1 with the optional level enumeration used to construct a logger on a client.
Background & Motivation
The documentation team ran into an issue when attempting to compare the optional log levels to those returned by the "Info" method in a custom log sink. See here for a detailed example.