Skip to content

Prevent replacing code with find and replace in read-only cells #16682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
krassowski merged 5 commits into from
Aug 19, 2024
Merged

Prevent replacing code with find and replace in read-only cells #16682

krassowski merged 5 commits into from
Aug 19, 2024

Conversation

@itsmevichu
Copy link
Member

@itsmevichu itsmevichu commented Aug 16, 2024

Fixes #16627

@jupyterlab-probot
Copy link

jupyterlab-probot bot commented Aug 16, 2024

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@itsmevichu itsmevichu marked this pull request as draft August 16, 2024 04:44
@krassowski krassowski added the bug label Aug 16, 2024
@itsmevichu itsmevichu marked this pull request as ready for review August 17, 2024 12:22
@krassowski krassowski added this to the 4.2.x milestone Aug 19, 2024
krassowski
krassowski approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @itsmevichu!

@krassowski krassowski changed the title Disabling find and replace for read-only cells Prevent replacing code with find and replace in read-only cells Aug 19, 2024
@krassowski krassowski merged commit 60aa967 into jupyterlab:main Aug 19, 2024
@krassowski
Copy link
Member

krassowski commented Aug 19, 2024

@meeseeksdev please backport to 4.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request Aug 19, 2024
@itsmevichu @meeseeksmachine
Backport PR jupyterlab#16682: Prevent replacing code with find and re…
f3b1c11 
…place in read-only cells
@meeseeksmachine meeseeksmachine mentioned this pull request Aug 19, 2024
Merged
@goekce goekce mentioned this pull request Aug 19, 2024
Open
krassowski pushed a commit that referenced this pull request Aug 19, 2024
@meeseeksmachine @itsmevichu
Backport PR #16682: Prevent replacing code with find and replace in r…
7bf7ec5 
…ead-only cells (#16696)

Co-authored-by: Vishnutheep B <[email protected]>
@krassowski krassowski mentioned this pull request Oct 23, 2024
Closed
ImpSy pushed a commit to spotinst/jupyterlab that referenced this pull request Jan 7, 2025
@itsmevichu @ImpSy
Prevent replacing code with find and replace in read-only cells (jupy…
3ad519b 
…terlab#16682)

* Disabling find-and-replace for read-only cells

* Adding unit test

* lint check
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krassowski krassowski krassowski approved these changes

Assignees

@itsmevichu itsmevichu

Labels

bug pkg:cells pkg:notebook

Projects

None yet

Milestone

4.2.x

Development

Successfully merging this pull request may close these issues.

Find & replace function also replaces text in read-only cells

2 participants

@itsmevichu @krassowski