New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement is_symlink #118

Merged

jaraco merged 3 commits into main from feature/is-symlink

May 26, 2024

Owner

jaraco commented May 26, 2024

Expand the alpharep fixture to include a symlink.
Revise test to capture new expectation.
Implement is_symlink.

jaraco added 3 commits

May 26, 2024 11:54


          Expand the alpharep fixture to include a symlink.

8f09d15


          Revise test to capture new expectation.

387dcea


          Implement is_symlink.

dc5fe8f

Closes #117

Owner Author

jaraco commented May 26, 2024

I've confirmed this behavior also works as intended for a zip file created outside Python:

 draft @ ln -s /etc/passwd passwd_link
 draft @ zip -ry test.zip passwd_link
  adding: passwd_link (stored 0%)
 draft [1] @ pip-run git+https://github.com/jaraco/zipp@refs/pull/118/head -- -c 'import zipp; print(zipp.Path("test.zip", "passwd_link").is_symlink())'
  WARNING: Did not find branch or tag 'refs/pull/118/head', assuming revision or ref.
True

jaraco merged commit 3a22d72 into main

28 checks passed

jaraco deleted the feature/is-symlink branch

May 26, 2024 16:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet