Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: isaacs/node-glob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v10.3.9
Choose a base ref
...
head repository: isaacs/node-glob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v10.3.10
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 27, 2023

  1. [email protected]

    @isaacs
    isaacs committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e57c2e1 View commit details
    Browse the repository at this point in the history

  2. Restore top level main, types 

    Trying the approach of "type:module, cjs main".

There are scenarios with TS 5.1 where this will result in incorrect
types being loaded, if `module` and `moduleResolution` do not match.

However, this is a smaller hazard than not being able to use the module
at all. And the only node versions which would potentially be confused
by the "type:module" and a cjs main are long out of support (as in, they
can't even load the code, because they also didn't support private class
members), so that's not a relevant consideration.

If this does work and resolve the issue without any negative
consequences arising for a while, I'll make it the default for tshy, so
that it does not require an additional opt-in configuration.

Fix: #557
    @isaacs
    isaacs committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    58a3b25 View commit details
    Browse the repository at this point in the history

  3. 10.3.10

    @isaacs
    isaacs committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    4f18d23 View commit details
    Browse the repository at this point in the history
Loading