Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: isaacs/node-glob
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v10.3.8
Choose a base ref
...
head repository: isaacs/node-glob
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v10.3.9
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Sep 26, 2023

  1. Revert "bring back main/types for ancient outdated node versions" 

    This reverts commit 7d7b115.

The problem is that anyone who isn't setting `moduleResolution` such
that exports can be parsed, will be trying to load ESM types as if they
were CommonJS, which is the whole reason for removing top level
main/types in the first place.

There seems to be no way to make this work that is both correct for
contemporary tooling, and compatible with node versions that have been
dead for years. We must choose the future.

Fix: #559
    @isaacs
    isaacs committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    00b5ca2 View commit details
    Browse the repository at this point in the history

  2. 10.3.9

    @isaacs
    isaacs committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b35083a View commit details
    Browse the repository at this point in the history
Loading