Revert "stub: Ignore unary response on server if status is not OK" #11636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
added
the
TODO:backport
kannanjgithub
approved these changes
Oct 25, 2024
ejona86
added a commit
to ejona86/grpc-java
that referenced
this pull request
Oct 25, 2024
…rpc#11636) This reverts commit 99f8683. The change doesn't handle `null` messages, which don't happen with protobuf, but can happen with other marshallers, especially in tests. See cl/689445172 This will reopen grpc#5969.
ejona86
removed
the
TODO:backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 99f8683.
The change doesn't handle
nullmessages, which don't happen with protobuf, but can happen with other marshallers, especially in tests. See cl/689445172This will reopen #5969
CC @NaveenPrasannaV