xds: use slices.Equal to simplify code #8472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8472 +/- ##
==========================================
- Coverage 82.31% 82.30% -0.02%
==========================================
Files 414 413 -1
Lines 40464 40513 +49
==========================================
+ Hits 33308 33344 +36
- Misses 5791 5798 +7
- Partials 1365 1371 +6
🚀 New features to boost your workflow:
|
Contributor
Author
Signed. |
arjan-bal
reviewed
Jul 24, 2025
arjan-bal
reviewed
Jul 24, 2025
Signed-off-by: jishudashu <[email protected]>
arjan-bal
approved these changes
Jul 24, 2025
Contributor
arjan-bal
left a comment
arjan-bal
left a comment
There was a problem hiding this comment.
LGTM, adding a second reviewer.
arjan-bal
changed the title
dfawley
approved these changes
Jul 24, 2025
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Go 1.21 standard library, a new function has been introduced that enhances code conciseness and readability. It can be find here.
RELEASE NOTES: N/A