transport: release mutex before returning on expired deadlines in server streams #8451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Bug
Area: Transport
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8451 +/- ##
==========================================
+ Coverage 82.27% 82.46% +0.19%
==========================================
Files 414 414
Lines 40422 40437 +15
==========================================
+ Hits 33257 33347 +90
+ Misses 5799 5743 -56
+ Partials 1366 1347 -19
🚀 New features to boost your workflow:
|
arjan-bal
changed the title
dfawley
approved these changes
Jul 15, 2025
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
Argh, sorry I missed this from the previous section. I will see about adding a system-level test for this, too
Pranjali-2501
pushed a commit
that referenced
this pull request
Jul 16, 2025
eshitachandwani
pushed a commit
to eshitachandwani/grpc-go
that referenced
this pull request
Jul 17, 2025
Pranjali-2501
pushed a commit
to Pranjali-2501/grpc-go
that referenced
this pull request
Jul 17, 2025
arjan-bal
added a commit
that referenced
this pull request
Jul 17, 2025
* xdsclient: preserve original bytes for decoding when the resource is wrapped (#8411) * xds: Avoid error logs when setting fallback bootstrap config (#8419) * xdsclient: relay marshalled bytes of complete resource proto to decoders (#8422) * xds: give up pool lock before closing xdsclient channel (#8445) * transport: release mutex before returning on expired deadlines in server streams (#8451) --------- Co-authored-by: Easwar Swaminathan <[email protected]> Co-authored-by: Arjan Singh Bal <[email protected]> Co-authored-by: Purnesh Dixit <[email protected]> Co-authored-by: Doug Fawley <[email protected]>
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8439 introduced the change to return early when the deadline has already expired. This causes the server mutex to be held forever.
Example failure in CI: https://github.com/grpc/grpc-go/actions/runs/16282058322/job/45973508273?pr=8437
RELEASE NOTES: N/A