cherry-pick #8343 to 1.73.x #8382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add flag guarding SPIFFE Bundle provider * remove the log * vet * address PR comments * add comment * fix typo * rename flag * add test * vet * add other flag check * remove check from watcher * add tests for new section where the spiffe bundle map file is set to empty string * vet
eshitachandwani
added
the
Type: Security
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.73.x #8382 +/- ##
===========================================
- Coverage 82.34% 82.21% -0.14%
===========================================
Files 419 419
Lines 42015 42021 +6
===========================================
- Hits 34599 34549 -50
- Misses 5965 6007 +42
- Partials 1451 1465 +14
🚀 New features to boost your workflow:
|
Contributor
|
@eshitachandwani is anything pending here? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #8343
Per grpc/proposal@master/A87-mtls-spiffe-support.md this feature should be guarded by an environment variable, GRPC_EXPERIMENTAL_XDS_MTLS_SPIFFE
RELEASE NOTES: