ringhash: Replace DNS resolver before sending xDS Update in test #8091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Bug
Area: Testing
arjan-bal
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8091 +/- ##
==========================================
+ Coverage 82.20% 82.23% +0.03%
==========================================
Files 387 387
Lines 38928 38962 +34
==========================================
+ Hits 31999 32040 +41
+ Misses 5606 5599 -7
Partials 1323 1323 |
dfawley
approved these changes
Feb 14, 2025
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7993
Updating the DNS resolver after sending the xDS update could result in clusterresolver using the real DNS resolver and timing out. This PR ensures the real DNS resolver is replaced before the xDS update with the logical DNS cluster is sent.
Tested
Verified the test no longer fails in 10^5 runs on forge.
RELEASE NOTES: N/A