cleanup: Fix usages of non-constant format strings #7959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Internal Cleanup
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7959 +/- ##
==========================================
+ Coverage 82.04% 82.22% +0.18%
==========================================
Files 379 379
Lines 38261 38261
==========================================
+ Hits 31391 31462 +71
+ Misses 5565 5506 -59
+ Partials 1305 1293 -12
|
dfawley
approved these changes
Dec 23, 2024
dfawley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.24 includes a vet rule that catches non-constant format strings: golang/go#60529. This causes
go testto fail unless vet is disabled when using go1.24.RELEASE NOTES: None