String format validator #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristonianJones
force-pushed
the
string-format-validate
branch
from
1989e9d to
3dc15dc
Compare
Collaborator
Author
|
@DangerOnTheRanger would you mind taking a look to see if this matches your expectations? |
TristonianJones
force-pushed
the
string-format-validate
branch
from
3dc15dc to
0e1d73d
Compare
Contributor
DangerOnTheRanger
left a comment
DangerOnTheRanger
left a comment
There was a problem hiding this comment.
Just had a couple small comments, nothing major or anything - LGTM otherwise.
jpbetz
reviewed
Jul 19, 2023
Contributor
jpbetz
left a comment
jpbetz
left a comment
There was a problem hiding this comment.
The way the options are configured (enabled by default) LGTM.
I'll defer to @DangerOnTheRanger on any specifics of the formatting code.
TristonianJones
force-pushed
the
string-format-validate
branch
from
2703956 to
77f4dd4
Compare
Contributor
|
LGTM |
jcking
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shift string format validation into the
ext.Strings()library.This change also removes all references to the string format extensions within
the cel and interpreter packages, and shifts validation from an
InterpretableDecoratorto an
cel.ASTValidatorwhich is applied immediately after type-checking.Note to reviewers: the majority of the changes are present in the
ext/formatting.gofile, and contained within the
stringFormatValidator. There are some subtle differencessuch as the new validator checks by function name only, and not by overload id (this
will be addressed in a future PR), and the argument length check applies to the original
call signature (size 1) rather than the internal call signature which includes the call
target as the first argument (size 2). Most of the rest of the code is quite similar
to what existed beforehand.
Closes #638