Add Thumbprint support for opaque signers #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows getting a thumbprint for the type OpaqueSigner. So if a key is backed by a custom signer, for example, a YubiKey or a cloud signer, we should be able to get the thumbprint for it as long as the public key is one of the supported ones. Signed-off-by: Mariano Cano <[email protected]>
pgporada
requested changes
Mar 15, 2023
Collaborator
|
Thank you for submitting this PR, sorry that it has lingered for so long. Tell Jenessa hey! |
aarongable
approved these changes
Mar 16, 2023
pgporada
approved these changes
Mar 17, 2023
mcpherrinm
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allows getting a thumbprint for the type OpaqueSigner. So if a key is backed by a custom signer, for example, a YubiKey or a cloud signer, we should be able to get the thumbprint for it as long as the public key is one of the supported ones.