doc: in v3 branch's README, point to v4 as latest #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcpherrinm
reviewed
Mar 6, 2024
README.md
Outdated
| import "github.com/go-jose/go-jose/v4" | ||
|
|
||
| The old [square/go-jose](https://github.com/square/go-jose) repo contains the prior v1 and v2 versions, which | ||
| are still useable but not actively developed anymore. |
Collaborator
There was a problem hiding this comment.
I think we should just drop the "which are are still usable" here. No use in actively promoting old versions
Collaborator
Author
There was a problem hiding this comment.
Changed to say "deprecated", which is what the square/go-jose repo itself says.
mcpherrinm
approved these changes
Mar 6, 2024
Also: - move the Versions stanza to the top - remove the Help Wanted - remove the doc / build badges Since this is not the main branch, it will mainly be viewed on pkg.go.dev after we make a patchlevel release.
mcpherrinm
approved these changes
Mar 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Since this is not the main branch, it will mainly be viewed on pkg.go.dev after we make a patchlevel release.