Fix support for write-only properties in BeEquivalentTo #2836
+14
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
dennisdoomen
force-pushed
the
fix/write-only-properties
branch
from
d2d2b6b
to
617eef4
Compare
dennisdoomen
force-pushed
the
fix/write-only-properties
branch
3 times, most recently
from
7b3f5f3
to
bc59834
Compare
dennisdoomen
force-pushed
the
fix/write-only-properties
branch
from
bc59834
to
d377ab4
Compare
Pull Request Test Coverage Report for Build 12005351325Details
💛 - Coveralls |
|
I'll try to have a look today. |
|
Is it intentional that this PR also contains the "Drop support..." commit? |
Yes, it needs to rebased when #2835 is merged. |
jnyrup
approved these changes
Nov 24, 2024
…ause a NRE. The implementation of Type.GetProperties that Reflectify provided crashed on a write-only property that is part of an interface. We didn't have a test for that, and the only other test that covered a similar scenario wasn't properly implemented.
dennisdoomen
force-pushed
the
fix/write-only-properties
branch
from
d377ab4
to
302d021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2832
The implementation of
Type.GetPropertiesthat Reflectify provided crashed on a write-only property that is part of an interface. We didn't have a test for that, and the only other test that covered a similar scenario wasn't properly implemented.Note Needs to rebased when #2835 is merged.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome