Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for .NET Core 2.1, 3.0 and NSpec #2835

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Drop support for .NET Core 2.1, 3.0 and NSpec #2835

merged 1 commit into from
Nov 25, 2024

Conversation

dennisdoomen
Copy link
Member

Drops support for .NET Core 2.1, 3.0 and NSpec, which are not supported by the community as well.

This will become version 7.0 and all bug fixes will land here. New features will go to 8.0.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 23, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@dennisdoomen dennisdoomen force-pushed the drop-unsupported-frameworks branch 4 times, most recently from 15705a9 to 791b22e Compare November 23, 2024 16:39
@coveralls
Copy link

coveralls commented Nov 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11990146301

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 97.364%
Totals Coverage Status
Change from base Build 11987789599: 0.07%
Covered Lines: 12932
Relevant Lines: 13168
💛 - Coveralls

jnyrup
jnyrup requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

.github/ISSUE_TEMPLATE/01_bug_report.yml Outdated Show resolved Hide resolved
docs/_pages/releases.md Show resolved Hide resolved
docs/_pages/releases.md Show resolved Hide resolved
@dennisdoomen
Copy link
Member Author

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

Are you suggesting not to do this?

@jnyrup
Copy link
Member

jnyrup commented Nov 23, 2024

A historical note: The last time we removed support for a framework was in #1227 almost five years ago.
I hope people have upgraded their projects by now, since 2.1 and 3.0 went EOL on August 21, 2021 and December 13, 2022, respectively

Are you suggesting not to do this?

Not at all, it was meant to show how supportive I think we've been for old/EOL frameworks.
I'm all for this PR 🚀

@dennisdoomen dennisdoomen mentioned this pull request Nov 24, 2024
Merged
7 tasks
@dennisdoomen dennisdoomen enabled auto-merge (squash) November 25, 2024 06:03
@dennisdoomen dennisdoomen merged commit 5fa83e2 into fluentassertions:master Nov 25, 2024
5 checks passed
@dennisdoomen dennisdoomen deleted the drop-unsupported-frameworks branch November 25, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisdoomen @coveralls @jnyrup