Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logs when using FIREBASE_DATACONNECT_POSTGRESQL_STRING #7882

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

joehan
Copy link
Contributor

@joehan joehan commented Oct 28, 2024

Description

Fixing a couple logging bugs that made it seem like PGLite was running even when FIREBASE_DATACONNECT_POSTGRESQL_STRING was used.

Scenarios Tested

With FIREBASE_DATACONNECT_POSTGRESQL_STRING (corrected the capitalization inconsistency on the log label)
Screenshot 2024-10-28 at 3 29 00 PM

Without:
Screenshot 2024-10-28 at 3 27 00 PM

@joehan joehan requested review from hlshen and yuchenshi October 28, 2024 23:07
@@ -310,6 +310,9 @@ You can probably fix this by running "npm install ${systemLog.data.name}@latest"
case "BULLET":
utils.logLabeledBullet(label, text, "info", mergedData);
break;
case "INFO":
utils.logLabeledBullet(label, text, "info", mergedData);
Copy link
Member

@yuchenshi yuchenshi Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this in addition to BULLET?

@joehan joehan merged commit 81dca8f into master Nov 12, 2024
43 of 45 checks passed
@joehan joehan deleted the jh-no-pglite branch November 12, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants