Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.x: Upgrading merge-descriptors with allowing minors #5782

Merged
merged 5 commits into from
Aug 23, 2024
Merged

5.x: Upgrading merge-descriptors with allowing minors #5782

merged 5 commits into from
Aug 23, 2024

Conversation

RobinTail
Copy link
Contributor

Similar to #5781 but for v5, with allowing minors according to the following request:
#5781 (comment)

RobinTail
RobinTail commented Jul 22, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@RobinTail RobinTail mentioned this pull request Jul 22, 2024
Merged
@wesleytodd wesleytodd changed the base branch from 5.x to 5.0 July 25, 2024 21:54
@wesleytodd wesleytodd added the 5.x label Jul 25, 2024
This was referenced Aug 15, 2024
Closed
Closed
@IamLizu
Copy link
Member

IamLizu commented Aug 23, 2024

Hi @RobinTail 👋

I hope you are doing fine. I am requesting you to move it v2. The idea is to upgrade all the dependencies first and then make node 18 as the minimum supported for express 5.

@RobinTail
Copy link
Contributor Author

RobinTail commented Aug 23, 2024 •
edited
Loading

done, @IamLizu && @wesleytodd

IamLizu
IamLizu reviewed Aug 23, 2024
View reviewed changes
Copy link
Member

@IamLizu IamLizu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

A minor thing, could you please add this in the unreleased section in History file?

Edit: just letting you know that deps should be in alphabetical order.

@RobinTail
Copy link
Contributor Author

A minor thing, could you please add this in the unreleased section in History file?

done, @IamLizu

IamLizu
IamLizu suggested changes Aug 23, 2024
View reviewed changes
History.md Outdated Show resolved Hide resolved
IamLizu
IamLizu approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@IamLizu IamLizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@wesleytodd wesleytodd merged commit 0b243b1 into expressjs:5.0 Aug 23, 2024
7 of 20 checks passed
This was referenced Oct 28, 2024
Open
Open
Open
@EchoSkorJjj EchoSkorJjj mentioned this pull request Oct 29, 2024
Open
This was referenced Oct 30, 2024
Open
Open
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 3, 2024
Open
@EchoSkorJjj EchoSkorJjj mentioned this pull request Nov 5, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Nov 10, 2024
Open
@doperiddle doperiddle mentioned this pull request Nov 10, 2024
Merged
@Gabo-Tech Gabo-Tech mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IamLizu IamLizu IamLizu approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@wesleytodd wesleytodd wesleytodd approved these changes

Assignees
No one assigned
Labels
5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RobinTail @IamLizu @wesleytodd @UlisesGascon