Call callback once on listen error #3216
Conversation
wesleytodd
force-pushed
the
server-listen-error
branch
2 times, most recently
from
8bec8cd to
32c8074
Compare
|
For some reason the test is not happy on Node.js 0.10. That may not actually be a problem with Express 5.0 target, just wanted to call out why the CI failed on this one (for now). |
wesleytodd
force-pushed
the
server-listen-error
branch
from
32c8074 to
cf5ce72
Compare
|
Oh, this is a change since 0.12, but if the server fails to start, calling |
|
Anything blocking this from merging? |
|
Do you have enough permissions to merge it now, @wesleytodd ? |
|
I had enough permissions back then I think, I was just more making sure we had agreement 😄. I will be re-visiting these pr's over the week and will land them as we are sure they are good. |
wesleytodd
force-pushed
the
server-listen-error
branch
from
cf5ce72 to
103e711
Compare
|
I updated this, but I would like a second look from @expressjs/express-tc or others to double check since this is soooooo old. If no one has opposed this change or given feedback I will merge it later this week. |
This is a redo of #2623. Probably didn't need a new PR, but I took a new direction by using the
oncemodule, and only binding to the error event. I think this is slightly more elegant than the previous PR. As discussed, this is a breaking change, so can only land in a 5.x branch.