Skip to content

Conversation

@mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

Adds defaultOptions to RulesMeta in @eslint/core types.

What changes did you make? (Give an overview)

Copied this:

https://github.com/eslint/eslint/blob/758c66bc8d83cd4eda9639b0745f0d0fb70f04f4/lib/types/index.d.ts#L744-L745

Also added schema, defaultOptions, and context.options in tests.

Related Issues

eslint/eslint#17656

Is there anything you'd like reviewers to focus on?

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@nzakas nzakas merged commit e9a987e into main Jan 31, 2025
18 checks passed
@nzakas nzakas deleted the default-options branch January 31, 2025 16:41
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants