Skip to content

Conversation

@nzakas
Copy link
Member

@nzakas nzakas commented Jan 30, 2025

Prerequisites checklist

What is the purpose of this pull request?

Update the RuleDefinition type.

What changes did you make? (Give an overview)

Related Issues

Refs eslint/eslint#19238

Is there anything you'd like reviewers to focus on?

I think it's okay to merge in the deprecation changes before eslint/eslint#19238, as the types here will apply to all plugins first and later be adopted by the core.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 4964322 into main Jan 31, 2025
18 checks passed
@mdjermanovic mdjermanovic deleted the deprecation-types branch January 31, 2025 12:46
@github-actions github-actions bot mentioned this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants