Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 29, 2025

🤖 I have created a release beep boop

compat: 1.2.6

1.2.6 (2025-01-31)

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • devDependencies
      • @eslint/core bumped from ^0.10.0 to ^0.11.0
config-array: 0.19.2

0.19.2 (2025-01-31)

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @eslint/object-schema bumped from ^2.1.5 to ^2.1.6
core: 0.11.0

0.11.0 (2025-01-31)

Features

  • Update RuleDefinition for frozen and deprecations (#149) (4964322)
  • Update RuleDefinition with meta.defaultOptions (#150) (e9a987e)

Bug Fixes

migrate-config: 1.3.7

1.3.7 (2025-01-31)

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @eslint/compat bumped from ^1.2.5 to ^1.2.6
object-schema: 2.1.6

2.1.6 (2025-01-31)

Bug Fixes

plugin-kit: 0.2.6

0.2.6 (2025-01-31)

Bug Fixes

Dependencies

  • The following workspace dependencies were updated
    • dependencies
      • @eslint/core bumped from ^0.10.0 to ^0.11.0

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--main branch 2 times, most recently from 64d1022 to e250a02 Compare January 31, 2025 12:46
@github-actions github-actions bot force-pushed the release-please--branches--main branch from e250a02 to 8c2f9ed Compare January 31, 2025 16:41
@nzakas nzakas merged commit e1cb603 into main Jan 31, 2025
3 checks passed
@nzakas nzakas deleted the release-please--branches--main branch January 31, 2025 17:21
@github-actions
Copy link
Contributor Author

@AviVahl
Copy link

AviVahl commented Feb 8, 2025

@nzakas the release job seems to have failed due to 503 Service Unavailable (https://github.com/eslint/rewrite/actions/runs/13077607982/job/36493504038)
this caused @eslint/plugin-kit to not actually get released (https://www.npmjs.com/package/@eslint/plugin-kit), and the latest release of eslint to have two different @eslint/core versions.

@fasttime
Copy link
Member

fasttime commented Feb 8, 2025

@nzakas the release job seems to have failed due to 503 Service Unavailable (https://github.com/eslint/rewrite/actions/runs/13077607982/job/36493504038) this caused @eslint/plugin-kit to not actually get released (https://www.npmjs.com/package/@eslint/plugin-kit), and the latest release of eslint to have two different @eslint/core versions.

Hi @AviVahl, thanks for letting us know. Indeed it was already noticed that the last @eslint/plugin-kit release wasn't published correctly, but we thought that wouldn't be a problem because there were no important changes in that package since the previous release.

Are you having an issue because there are now different versions of the @eslint/core package in the same installation, or is it just the redundancy that bothers you?

@AviVahl
Copy link

AviVahl commented Feb 8, 2025

My experience thought me that duplicate versions of such core packages can cause many unexpected issues downstream, so before upgrading 40+ repositories that use eslint, I thought I'd let you know.

If you want a technical reason to fix this:
one won't be able to leverage the DeprecatedInfo interface introduced in #149 in cases where the old version is installed in the root node_modules, with the new version not getting hoisted. e.g. https://github.com/wixplosives/mocha-play/pull/728/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R2131

EDIT: stylable repository, after getting upgraded to the new version:
image

@fasttime
Copy link
Member

fasttime commented Feb 8, 2025

My experience thought me that duplicate versions of such core packages can cause many unexpected issues downstream, so before upgrading 40+ repositories that use eslint, I thought I'd let you know.

Thanks! We didn't consider that.

If you want a technical reason to fix this: one won't be able to leverage the DeprecatedInfo interface introduced in #149 in cases where the old version is installed in the root node_modules, with the new version not getting hoisted. e.g. https://github.com/wixplosives/mocha-play/pull/728/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R2131

EDIT: stylable repository, after getting upgraded to the new version: image

I think in the case of the code snippet you are showing the type definition for the createRule method comes from @typescript-eslint/utils, where the new DeprecatedInfo hasn't been implemented yet:

https://github.com/typescript-eslint/typescript-eslint/blob/v8.23.0/packages/utils/src/ts-eslint/Rule.ts#L35-L38

In this case, upgrading @eslint/core in transitive eslint dependencies like @eslint/plugin-kit won't help. The best you could do is filing an issue at typescript-eslint to make them aware of the problem.

@AviVahl
Copy link

AviVahl commented Feb 8, 2025

Ah, I've assumed that type was coming from the @eslint/core package. Anyway, the point still stands, as the scenario is possible, and happened to me with other packages in the past. I appreciate you looking into it, nonetheless.

@AviVahl
Copy link

AviVahl commented Feb 9, 2025

btw, re-reading your comment, I'm no longer sure whether you're really thankful for my input, or being sarcastic.

@fasttime
Copy link
Member

fasttime commented Feb 9, 2025

@AviVahl It's always a good idea to let us know if you suspect a problem on our end. This kind of feedback is genuinely appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants