fix: report locations in no-multiple-h1 and require-alt-text
#551
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I'm not sure how |
Member
Author
|
Seems that |
Contributor
|
dmnd/dedent#101, perhaps? |
Member
Author
Yes, looks like that is exactly the same problem. I've just updated the added tests to not use |
JoshuaKGoldberg
approved these changes
Oct 3, 2025
Contributor
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
LGTM 👍. Leaving open for a second review because this is tricky code unit logic.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
Merged
This was referenced Oct 4, 2025
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Fixes report location in the
no-multiple-h1andrequire-alt-textrules in cases where a preceding HTML comment has characters consisting of Unicode surrogate pairs.What changes did you make? (Give an overview)
Updated
utils.stripHtmlCommentsto replace each code unit (instead of code point) with a space. This preserves offsets and locations of characters outside HTML comments.Related Issues
Is there anything you'd like reviewers to focus on?