feat: preserve-caught-error should recognize all static "cause" keys (#20163)

Pixel998 · web-flow · commit 39f7fb493a69 · 2025-09-29T17:21:21.000+05:30
diff --git a/lib/rules/preserve-caught-error.js b/lib/rules/preserve-caught-error.js
@@ -82,11 +82,7 @@ function getErrorCause(throwStatement) {
 			}
 
 			const causeProperties = errorOptions.properties.filter(
-				prop =>
-					prop.type === "Property" &&
-					prop.key.type === "Identifier" &&
-					prop.key.name === "cause" &&
-					!prop.computed, // It is hard to accurately identify the value of computed props
+				prop => astUtils.getStaticPropertyName(prop) === "cause",
 			);
 
 			const causeProperty = causeProperties.at(-1);
diff --git a/tests/lib/rules/preserve-caught-error.js b/tests/lib/rules/preserve-caught-error.js
@@ -23,6 +23,31 @@ ruleTester.run("preserve-caught-error", rule, {
     } catch (error) {
         throw new Error("Failed to perform error prone operations", { cause: error });
     }`,
+		`try {
+		doSomething();
+	} catch (error) {
+		throw new Error("Something failed", { 'cause': error });
+	}`,
+		`try {
+		doSomething();
+	} catch (error) {
+		throw new Error("Something failed", { "cause": error });
+	}`,
+		`try {
+		doSomething();
+	} catch (error) {
+		throw new Error("Something failed", { ['cause']: error });
+	}`,
+		`try {
+		doSomething();
+	} catch (error) {
+		throw new Error("Something failed", { ["cause"]: error });
+	}`,
+		`try {
+		doSomething();
+	} catch (error) {
+		throw new Error("Something failed", { [\`cause\`]: error });
+	}`,
 		/* No throw inside catch */
 		`try {
         doSomething();
@@ -92,6 +117,16 @@ ruleTester.run("preserve-caught-error", rule, {
 		} catch (error) {
 			throw new Error("Something failed", { cause: anotherError, cause: error });
 		}`,
+		`try {
+			doSomething();
+		} catch (error) {
+			throw new Error("Something failed", { "cause": anotherError, "cause": error });
+		}`,
+		`try {
+			doSomething();
+		} catch (error) {
+			throw new Error("Something failed", { cause: anotherError, "cause": error });
+		}`,
 	],
 	invalid: [
 		/* 1. Throws a new Error without cause, even though an error was caught */
@@ -136,6 +171,30 @@ ruleTester.run("preserve-caught-error", rule, {
         } catch (err) {
             const unrelated = new Error("other");
             throw new Error("Something failed", { cause: err });
+        }`,
+						},
+					],
+				},
+			],
+		},
+		{
+			code: `try {
+            doSomething();
+        } catch (err) {
+            const unrelated = new Error("other");
+            throw new Error("Something failed", { "cause": unrelated });
+        }`,
+			errors: [
+				{
+					messageId: "incorrectCause",
+					suggestions: [
+						{
+							messageId: "includeCause",
+							output: `try {
+            doSomething();
+        } catch (err) {
+            const unrelated = new Error("other");
+            throw new Error("Something failed", { "cause": err });
         }`,
 						},
 					],
@@ -735,6 +794,12 @@ ruleTester.run("preserve-caught-error", rule, {
 			}`,
 			errors: [{ messageId: "incorrectCause" }],
 		},
+		{
+			code: `try {} catch (error) {
+				throw new Error("Something failed", { cause: error, "cause": anotherError });
+			}`,
+			errors: [{ messageId: "incorrectCause" }],
+		},
 		/* 26. Getters and setters as `cause`. */
 		{
 			code: `try {} catch (error) {
