Fixed a regression that caused changeset version to fail on packages having a dev dependency on a skipped package
#1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s having a dev dependency on a skipped package
🦋 Changeset detectedLatest commit: 7fa36fa The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1370 +/- ##
==========================================
+ Coverage 80.89% 80.95% +0.06%
==========================================
Files 54 54
Lines 2204 2211 +7
Branches 646 657 +11
==========================================
+ Hits 1783 1790 +7
Misses 417 417
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Andarist
commented
May 28, 2024
| @@ -100,6 +100,41 @@ describe("cli", () => { | |||
| expect(loggerErrorCalls.length).toEqual(0); | |||
| }); | |||
|
|
|||
| it("should not throw on a dev dependent on an unversioned private package", async () => { | |||
There was a problem hiding this comment.
a similar scenario was already buggy before this recent regression, see:
#1361 (comment)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.