Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade human-id to v4 #1457

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

benmccann
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Sep 15, 2024

⚠️ No Changeset found

Latest commit: b133abe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (400ab7b) to head (b133abe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1457   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          54       54           
  Lines        2213     2213           
  Branches      658      658           
=======================================
  Hits         1793     1793           
  Misses        416      416           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andarist
Copy link
Member

This package has no changelog 😅 how can I double-check that this won't break anything? Can you identify reasons behind each major bump since v1?

@benmccann
Copy link
Contributor Author

They're just bumping version numbers willy-nilly:
2.0 was typescript upgrade: RienNeVaPlus/human-id@1ad2c86
3.0 changed nothing of note
4.0 removed the jsnext:main field: RienNeVaPlus/human-id@81dd626

@Andarist
Copy link
Member

Could you resolve the conflict?

@Andarist Andarist merged commit db79dc9 into changesets:main Sep 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants