Update metadata test #1024
Merged
Update metadata test #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Does this PR introduce a breaking change?
Other information:
In this PR we rewrite the metadata test so that we can get rid of webpack deprecation warning due to the usage in
react-intl-webpack-plugin. The new test focuses on the behavior ofmetadataSubscribers, where we drafted minimal Babel plugin and webpack plugin to ensure that this feature works.The previous test is an integration test with
react-intl, however, thebabel-plugin-react-intlhas been renamed asbabel-plugin-formatjsand the usage also evolved a lot. The current integration test might not reflect the best practice anymore, so I suggest to remove previous tests.