Implement `import defer` proposal transform support #15878

nicolo-ribaudo · 2023-08-21T15:30:35Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This PR implements transform support for the Stage 2 Deferred Import Evaluation (import defer), for which parsing support has been implemented in #15845. It is only supported when compiling modules to CommonJS.

This PR can be reviewed commit-by-commit, and after each commit tests&linting were green:

[helper-module-transforms] Support customizing require&reference allows passing two functions to @babel/helper-module-transforms to customize how references to imported modules are transformed:
- getWrapperPayload allow computing some opaque payload given some metadata representing the imported module. This payload is then both used to decide how to transform references to imported bindings, and exposed to callers of this helper package.
- wrapReference allows wrapping the AST node referencing the imported bindings, given the payload computed by the function above.
The implementation of lazy imports, supported when compiling ESM to CJS, has been rewritten on top of these two new customization functions and extracted to packages/babel-helper-module-transforms/src/lazy-modules.ts, rather than being mixed with the main transform logic.
Support hooks in commonjs plugin, and implement lazy as a hook allows other plugins to hook into the ESM->CJS transform process. "Hooks" (or "plugins for the plugin" 😅) can provide their own implementation of getWrapperPayload and wrappReference, as well as a third function:
- buildRequireWrapper allows wrapping the require() AST node, given the payload computed by getWrapperPayload.
The lazy option has been re-implemented on top of use this new "hooks" system, so that it's now entirely contained in @babel/plugin-transform-modules-commonjs (which is the only modules transform that supports it) rather than half there and half in @babel/helper-module-transforms. @babel/helper-module-transforms still needs its own implementation for compatibility with older @babel/plugin-transform-modules-commonjs versions, but that code is not used when using newer @babel/plugin-transform-modules-commonjs and it can be easily removed in Babel 8.

Maybe this hooks system could also be used for transforming import source when compiling to CJS.
Add @babel/plugin-syntax-import-defer
Implement import defer proposal transform support implements import defer as a hook for @babel/plugin-transform-modules-commonjs. This uses an optimized version when possible, by mirroring the lazy implementation (i.e. put require() in a function and call it when needed to read a property from the module), falling back to a proxy-based version when the module namespace is referenced in other ways. Note that evaluation should only happen when reading the namespace's properties, and not when simply referencing it.

babel-bot · 2023-08-21T15:33:38Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55495/

nicolo-ribaudo · 2023-08-21T16:05:32Z

packages/babel-plugin-proposal-import-defer/src/index.ts

+  // We need the explicit type annotation otherwise when using t.assert* ts
+  // reports that 'Assertions require every name in the call target to be
+  // declared with an explicit type annotation'
+  const t: typeof api.types = api.types;


"Fun" fact: const a = b and const a: typeof b = b are not equivalent in TS.

microsoft/TypeScript#36931, https://www.typescriptlang.org/play?strictNullChecks=false&noImplicitReturns=false#code/C4TwDgpgBAKlC8UDeAoKUCGBnLAKAHgFxQBGA9mQDYQYB2AlMdlhAE7BZT4DcKAvrwAmEAMaUMraADMArrRHAAlmVpRWc3CJLFcwYjHoIAfFABuZRYMZmLg3imFiJ0asFLFyVGrXvrau42Q0KBEVLDcZBChgXnQAejiQsIjiUEgyKWiomOCZADpmXBJ6Xj4SlCA

JLHwung

Can you add this plugin to the babel standalone? So that we can come up with a REPL for this PR.

JLHwung · 2023-09-13T15:11:59Z

packages/babel-helper-module-transforms/src/index.ts

+    metadata: SourceModuleMetadata,
+    importNodes: t.Node[],
+  ) => unknown;
+  wrapReference?: (ref: t.Expression, payload: unknown) => t.Expression | null;


Nit: can we make this interface generic? So that TS knows that the payload passed into wrapReference must conforms to type of the return of getWrapperPayload.

Unfortunately, payload might be unknown because it might be generated by the hook of another plugin. The best we can do is

interface T { wrapReference?: (ref: t.Expression, payload: T | unknown) => t.Expression | null; }

which does not improve types (T | unknown is unknown) but it might improve autocompletion.

it might be generated by the hook of another plugin

Good point. That seems to be similar to the PluginPass's behaviour: Any plugin can augment the PluginPass but there is no guarantee that the PluginPass must not be changed by other plugins within the same pass.

JLHwung

Awesome work.

JLHwung · 2023-09-13T19:45:42Z

packages/babel-plugin-proposal-import-defer/src/index.ts

+        //   import "a"
+        // we have the correct evaluation order
+
+        const eagerImports = new Map();


Can it be simplified to a set?

JLHwung · 2023-09-13T19:54:09Z

packages/babel-plugin-transform-modules-commonjs/src/hooks.ts

+  name: string;
+  version: string;
+  wrapReference?(ref: t.Expression, payload: unknown): t.CallExpression | null;
+  buildRequireWrapper?(


Can you add a brief note about the behaviour difference between the return value false and null?

JLHwung · 2023-09-13T19:57:15Z

packages/babel-plugin-transform-modules-commonjs/src/lazy.ts

+    if (lazy === true) {
+      // 'true' means that local relative files are eagerly loaded and
+      // dependency modules are loaded lazily.
+      return /\./.test(source) ? null : "lazy/function";


There are a few libraries whose names contain .. We should revisit here.

Yeah, this should probably be .startsWith("."). I'm not editing in this PR to keep this as new-features-only.

JLHwung · 2023-09-13T20:04:20Z

packages/babel-standalone/src/preset-stage-2.ts

@@ -22,6 +22,7 @@ export default (_: any, opts: any = {}) => {
        babelPlugins.proposalRecordAndTuple,
        { syntaxType: recordAndTupleSyntax },
      ],
+      babelPlugins.proposalImportDefer,


We should enable this plugin only when opts.modules is commonjs or cjs.

These presets do not currently have a modules option, that's in preset-2015. Maybe a enableProposalImportDefer option, that we enable from the repl UI when we compile modules? 🤔

JLHwung · 2023-09-13T20:26:13Z

packages/babel-plugin-proposal-import-defer/src/index.ts

+            if (!referenced) return false;
+            return template.statement.ast`
+              function ${name}() {
+                const data = ${init};


The memoizer variable can also be injected from the function arguments.

Yeah we could do function ${name}(data = ${init}), but then compiling that down will generate bigger code because it has to check if data is undefined.

How about

function ${name}(data) { data = ${init} ... }

? So we can save the uncompressable const string.

function ${name}(data) { ${name} = () => data; return data = ${init}; }

:)

JLHwung · 2023-09-13T20:27:45Z

packages/babel-plugin-proposal-import-defer/src/index.ts

+            return template.statement.ast`
+              function ${name}() {
+                const data = ${init};
+                ${name} = () => data;


They will be handled by the arrow function transform if enabled right? If so we can sync the changes here to other wrappers, maybe in another PR.

Yes! However I prefer to avoid if possible starting emitting ES6 syntax in code that is currently generated as ES5-only, in case somebody still has a manual list of enabled plugins for the features they use.

JLHwung · 2023-09-13T20:34:03Z

packages/babel-helpers/src/helpers/importDeferProxy.js

@@ -0,0 +1,31 @@
+/* @minVersion 7.22.0 */
+export default function _importDeferProxy(init) {


It may be worthy of an assumption to get rid of this helper, since proxy is difficult to optimize and the helper will kick in when people are merely assigning an alias to the namespace object like const e = ns;. In this case they are not asking for any reflection support.

Would you expect const e = ns to trigger the evaluation of the module, under that option? Or should we track usages of e and transform them in calls that evaluate the module?

I think this helper will already be used very rarely, because most of the usages of "deferred namesapces" will just be people rewriting import { val } from "./x"; doSomethingWith(val) to import defer * as x from "./x"; doSomethingWith(x.val)

Or should we track usages of e and transform them in calls that evaluate the module?

I agree with this, but it could be in a future PR.

Would you expect const e = ns to trigger the evaluation of the module, under that option?

Good question. I think it should not trigger the evaluation. If const e = ns is called after ns.something, then e is the evaluated module, otherwise the uninitialized factory.

Right, which means we will need to track usages of e because we will need to replace e.something with e().something.

liuxingbaoyu

getWrapperPayload allow computing some opaque pa
yload given some metadata representing the imported module. This payload is then both used to decide how to transform references to imported bindings, and exposed to callers of this helper package.
wrapReference allows wrapping the AST node referencing the imported bindings, given the payload computed by the function above.

I really, really like this because it replaces the poor approach in my other PR with a really great design.

<p>This PR was automatically created by Snyk using the credentials of a real user.</p><br /><h3>Snyk has created this PR to upgrade multiple dependencies.</h3> 👯‍♂ The following dependencies are linked and will therefore be updated together. </br></br> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. </br></br> Name | Versions | Released on :-------------|:-------------|:------------- **@babel/parser**</br>from 7.22.16 to 7.23.0 | **1 version** ahead of your current version | **22 days ago**</br>on 2023-09-25 **@babel/types**</br>from 7.22.19 to 7.23.0 | **1 version** ahead of your current version | **22 days ago**</br>on 2023-09-25 <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@babel/parser</b></summary> <ul> <li> <b>7.23.0</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.23.0">2023-09-25</a></br><h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/lorenzoferre/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/RajShukla1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/RajShukla1">@ RajShukla1</a> for your first PRs!</p> <h4>🚀 New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15870" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15870/hovercard">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15878" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15878/hovercard">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15845" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15845/hovercard">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15829" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15829/hovercard">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15682" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15682/hovercard">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15671" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15671/hovercard">#15671</a> Pass through nonce to the transformed script element (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15751" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15751/hovercard">#15751</a> Add support for optional chain in assignments (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15895" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15895/hovercard">#15895</a> Implement the "decorator metadata" proposal (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15893" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15893/hovercard">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15913" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15913/hovercard">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15896" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15896/hovercard">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://snyk.io/redirect/github/yukukotani">@ yukukotani</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15962" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15962/hovercard">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15797" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15797/hovercard">#15797</a> Expand evaluation of global built-ins in <code>@ babel/traverse</code> (<a href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15985" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15985/hovercard">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🔬 Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15984" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15984/hovercard">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Lorenzo Ferretti (<a href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li>Raj Pawan Shukla (<a href="https://snyk.io/redirect/github/RajShukla1">@ RajShukla1</a>)</li> <li>Yuku Kotani (<a href="https://snyk.io/redirect/github/yukukotani">@ yukukotani</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.22.16</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.16">2023-09-06</a></br><h2>v7.22.16 (2023-09-06)</h2> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15935" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15935/hovercard">#15935</a> fix: <code>__esModule</code> is missing from published <code>@ babel/parser</code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>🏠 Internal</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15936" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15936/hovercard">#15936</a> Skip deprecation warning tests when in a folder named <code>@ babel</code> (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 3</h4> <ul> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/parser GitHub release notes</a> </details> <details> <summary>Package name: <b>@babel/types</b></summary> <ul> <li> <b>7.23.0</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.23.0">2023-09-25</a></br><h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/lorenzoferre/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a> and <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/RajShukla1/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://snyk.io/redirect/github/RajShukla1">@ RajShukla1</a> for your first PRs!</p> <h4>🚀 New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15870" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15870/hovercard">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15878" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15878/hovercard">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15845" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15845/hovercard">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15829" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15829/hovercard">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15682" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15682/hovercard">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15671" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15671/hovercard">#15671</a> Pass through nonce to the transformed script element (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15751" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15751/hovercard">#15751</a> Add support for optional chain in assignments (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15895" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15895/hovercard">#15895</a> Implement the "decorator metadata" proposal (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15893" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15893/hovercard">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15913" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15913/hovercard">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15896" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15896/hovercard">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://snyk.io/redirect/github/yukukotani">@ yukukotani</a>)</li> </ul> </li> </ul> <h4>🐛 Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15962" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15962/hovercard">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a>)</li> </ul> </li> </ul> <h4>💅 Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15797" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15797/hovercard">#15797</a> Expand evaluation of global built-ins in <code>@ babel/traverse</code> (<a href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15985" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15985/hovercard">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>🔬 Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://snyk.io/redirect/github/babel/babel/pull/15984" data-hovercard-type="pull_request" data-hovercard-url="/babel/babel/pull/15984/hovercard">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> </ul> </li> </ul> <h4>Committers: 7</h4> <ul> <li>Babel Bot (<a href="https://snyk.io/redirect/github/babel-bot">@ babel-bot</a>)</li> <li>Huáng Jùnliàng (<a href="https://snyk.io/redirect/github/JLHwung">@ JLHwung</a>)</li> <li>Lorenzo Ferretti (<a href="https://snyk.io/redirect/github/lorenzoferre">@ lorenzoferre</a>)</li> <li>Nicolò Ribaudo (<a href="https://snyk.io/redirect/github/nicolo-ribaudo">@ nicolo-ribaudo</a>)</li> <li>Raj Pawan Shukla (<a href="https://snyk.io/redirect/github/RajShukla1">@ RajShukla1</a>)</li> <li>Yuku Kotani (<a href="https://snyk.io/redirect/github/yukukotani">@ yukukotani</a>)</li> <li><a href="https://snyk.io/redirect/github/liuxingbaoyu">@ liuxingbaoyu</a></li> </ul> </li> <li> <b>7.22.19</b> - <a href="https://snyk.io/redirect/github/babel/babel/releases/tag/v7.22.19">2023-09-14</a></br><h2>v7.22.19 (2023-09-14)</h2> <p>Re-published 7.22.18, due to a releasing error.</p> </li> </ul> from <a href="https://snyk.io/redirect/github/babel/babel/releases">@babel/types GitHub release notes</a> </details> </details> <hr/> **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.* For more information: <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkYTdkYzgwNS0xMDczLTQxMWEtYWM1OC1mYTZjMTcyNTJjNzgiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImRhN2RjODA1LTEwNzMtNDExYS1hYzU4LWZhNmMxNzI1MmM3OCJ9fQ==" width="0" height="0"/> 🧐 [View latest project report](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603?utm_source=github&utm_medium=referral&page=upgrade-pr) 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/woodpile37/project/e5e31077-489f-44c1-b24d-4af9a1a8d603/settings/integration?pkg=@babel/parser&pkg=@babel/types&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Needs Docs labels Aug 21, 2023

nicolo-ribaudo commented Aug 21, 2023

View reviewed changes

nicolo-ribaudo force-pushed the feat-7.23.0/imports branch from bc5b525 to 90e9c58 Compare September 5, 2023 12:38

nicolo-ribaudo force-pushed the defer-import-transform branch from 0e36a0f to 6571dc3 Compare September 5, 2023 12:40

This was referenced Sep 6, 2023

Fix transform of named import with shadowed namespace import #15898

Merged

[Bug]: commonjs lazy transform produces invalid output with multiple ns imports for same module #15939

Closed

Import-related updates for 7.23.0 #15830

Merged

nicolo-ribaudo added this to the v7.23.0 milestone Sep 7, 2023

nicolo-ribaudo added the PR: Needs Review A pull request awaiting more approvals label Sep 7, 2023

nicolo-ribaudo requested review from JLHwung and liuxingbaoyu September 12, 2023 14:10

JLHwung added the Spec: Deferred Module Evaluation label Sep 13, 2023

JLHwung reviewed Sep 13, 2023

View reviewed changes

nicolo-ribaudo force-pushed the defer-import-transform branch from f46fd31 to 75f6224 Compare September 13, 2023 15:58

JLHwung approved these changes Sep 13, 2023

View reviewed changes

nicolo-ribaudo force-pushed the feat-7.23.0/imports branch from 90e9c58 to c5badb5 Compare September 14, 2023 11:04

nicolo-ribaudo force-pushed the defer-import-transform branch from 75f6224 to 33774f0 Compare September 14, 2023 11:08

liuxingbaoyu approved these changes Sep 15, 2023

View reviewed changes

nicolo-ribaudo force-pushed the feat-7.23.0/imports branch from c5badb5 to 65a6e85 Compare September 18, 2023 13:44

nicolo-ribaudo added 6 commits September 18, 2023 15:45

[helper-module-transforms] Support customizing require&reference

e4a8dc4

Support hooks in commonjs plugin, and implement lazy as a hook

12d05c7

Add @babel/plugin-syntax-import-defer

1901f6b

Implement import defer proposal transform support

6141a92

Add to standalone

ace7ee1

Review

691d725

nicolo-ribaudo force-pushed the defer-import-transform branch from 33774f0 to 691d725 Compare September 18, 2023 13:45

nicolo-ribaudo added 2 commits September 18, 2023 15:45

Remove from Stage 2 preset in standalone

39581c4

Reduce output size

ed3e000

nicolo-ribaudo removed the PR: Needs Review A pull request awaiting more approvals label Sep 18, 2023

nicolo-ribaudo merged commit 35c0651 into babel:feat-7.23.0/imports Sep 18, 2023
45 of 46 checks passed

nicolo-ribaudo deleted the defer-import-transform branch September 18, 2023 15:23

nicolo-ribaudo mentioned this pull request Sep 23, 2023

Add docs for new 7.23.0 plugins babel/website#2828

Merged

nicolo-ribaudo added a commit that referenced this pull request Sep 25, 2023

Implement import defer proposal transform support (#15878)

d922031

nicolo-ribaudo added a commit that referenced this pull request Sep 25, 2023

Implement import defer proposal transform support (#15878)

a65f18e

Omrisnyk mentioned this pull request Oct 16, 2023

[Snyk] Security upgrade @babel/traverse from 7.0.0 to 7.23.2 Omrisnyk/npm-lockfiles#121

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 19, 2023

github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `import defer` proposal transform support #15878

Implement `import defer` proposal transform support #15878

nicolo-ribaudo commented Aug 21, 2023 •

edited by gitpod-io bot

Loading

babel-bot commented Aug 21, 2023 •

edited

Loading

nicolo-ribaudo Aug 21, 2023 •

edited

Loading

JLHwung left a comment

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 13, 2023

JLHwung Sep 13, 2023

JLHwung left a comment

JLHwung Sep 13, 2023

JLHwung Sep 13, 2023

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 14, 2023

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 14, 2023

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 14, 2023

JLHwung Sep 18, 2023

nicolo-ribaudo Sep 18, 2023

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 14, 2023

JLHwung Sep 13, 2023

nicolo-ribaudo Sep 14, 2023

liuxingbaoyu Sep 15, 2023

JLHwung Sep 18, 2023

nicolo-ribaudo Sep 18, 2023

liuxingbaoyu left a comment

		@@ -0,0 +1,31 @@
		/* @minVersion 7.22.0 */
		export default function _importDeferProxy(init) {

Implement import defer proposal transform support #15878

Implement import defer proposal transform support #15878

Conversation

nicolo-ribaudo commented Aug 21, 2023 • edited by gitpod-io bot Loading

babel-bot commented Aug 21, 2023 • edited Loading

nicolo-ribaudo Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

JLHwung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JLHwung left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liuxingbaoyu left a comment

Choose a reason for hiding this comment

Implement `import defer` proposal transform support #15878

Implement `import defer` proposal transform support #15878

nicolo-ribaudo commented Aug 21, 2023 •

edited by gitpod-io bot

Loading

babel-bot commented Aug 21, 2023 •

edited

Loading

nicolo-ribaudo Aug 21, 2023 •

edited

Loading