Skip to content

Conversation

@jamesbraza
Copy link
Contributor

Closes #592

@jamesbraza jamesbraza requested a review from eifinger as a code owner October 1, 2025 16:23
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We don't need the "unset" case though

@jamesbraza jamesbraza requested a review from eifinger October 1, 2025 19:52
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the extra comments.

Please run npm run all to regenerate the distfolder. Otherwise CI will fail.

@eifinger eifinger changed the title Updated saveCache to give better error message when UV_CACHE_DIR has changed Warn when UV_CACHE_DIR has changed Oct 2, 2025
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eifinger eifinger merged commit f9c6974 into astral-sh:main Oct 2, 2025
76 checks passed
@jamesbraza jamesbraza deleted the fixing-teardown-message branch October 2, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird Cache path /home/runner/work/_temp/setup-uv-cache does not exist on disk after uv sync

2 participants