-
Notifications
You must be signed in to change notification settings - Fork 76
Warn when UV_CACHE_DIR has changed
#601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eifinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We don't need the "unset" case though
eifinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need the extra comments.
Please run npm run all to regenerate the distfolder. Otherwise CI will fail.
saveCache to give better error message when UV_CACHE_DIR has changedUV_CACHE_DIR has changed
eifinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Closes #592