-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wellformed the table's rowspan and/or colspan attributes #156
Conversation
optimized some jsdocs and added some |
Wellformed the table's rowspan and/or colspan attributes, usage sample below: | A | B | C | D |
| ----------------------- | --- | --- | ---------------- |
| 1 | 11 | 111 | 1111 {rowspan=3} |
| 2 {colspan=2 rowspan=2} | 22 | 222 | 2222 |
| 3 | 33 | 333 | 3333 |
{border=1} Output: <table border="1">
<thead>
<tr>
<th>A</th>
<th>B</th>
<th>C</th>
<th>D</th>
</tr>
</thead>
<tbody>
<tr>
<td>1</td>
<td>11</td>
<td>111</td>
<td rowspan="3">1111</td>
</tr>
<tr>
<td colspan="2" rowspan="2">2</td>
<td>22</td>
</tr>
<tr>
<td>3</td>
</tr>
</tbody>
</table> current looking view as:
before rending as:
transform the cells B222,B2222,B33,B333,B3333 to hidden. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋 Thanks for contributing
I must admit that the code is challenging, I do not know much about rowspan or colspan, and it has been some years since this code was written. I cannot totally grasp my own code either. The type-hinting will help, thank you for those!
If you could please answer my questions, I'll do a review soonish.
Thanks again 🙌
The rowspan and colspan are all the html standard for rending This improvement is solving the overflow cells, better for rendering. See the above notes. |
A real rendered markdown table (490 rows x 3 columns) is launched here. It looks expectation and no more time spent(from the GitHub actions). Hopes it may helpful. |
Hi there, feel free take a look this website https://wechatpay.im/openapi/, there were more than 790+ rendered pages with this feature. Hopes this pr may be merged. @arve0 |
Sorry for the delay. It's published with version 4.3.0. |
markdown-it
v14.npmignore
only with necessary files