fix: use ecmaVersion 'latest' per eslint's docs recommendation #756
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support for import attributes
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR switches to
ecmaVersion: 'latest'per recommendation from eslint documentation https://eslint.org/docs/latest/use/configure/language-options#specifying-javascript-options.For example current value of
ecmaVersion: 2022doesn't support import attributes which prevents eslint from parsing file when such import is encountered. This can be demonstrated in eslint's playground. Playground showsParsing error: Unexpected token withwhenUnexpected var, use let or const insteadshould be displayed instead.Few notes:
2025or even2026version but I guess we'll be still chasing similar issues each time new syntax gets added. Withlatestconfig stays in sync with what version of parser eslint ships.latestis default when config is omitted still thought it would be clearer to set it explicitly tolatest.Linked Issues
Discord conversation: https://discord.com/channels/937808017016119440/937977751472840704/1413393048817373245
Additional context
Not sure if this is a breaking change? Most likely not.