fix: broader the dev environment detection #748
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for melodious-froyo-4871f8 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
antfu
reviewed
Aug 8, 2025
src/utils.ts
Outdated
| return !!(false | ||
| || process.env.VSCODE_PID | ||
| || process.env.VSCODE_CWD | ||
| || Object.keys(process.env).find(value => /^VSCODE_.*/.test(value)) |
Owner
There was a problem hiding this comment.
I think this is way too broad and easy to lead to false positives. I'd prefer to list more known envs hard-coded.
Contributor
Author
There was a problem hiding this comment.
Ok.
Maybe process.env.TERM_PROGRAM === "vscode"?
This one is set in my VSCodium environment.
Contributor
Author
There was a problem hiding this comment.
Hi there,
I‘ve modified the code accordingly (see 8110667).
VSCodium does not set `VSCODE_PID` so it was not detected as a dev environment. The code now checks if "TERM_PROGRAM" variable is set to `vscode` instead. See [code in `addTerminalEnvironmentKeys` function](https://github.com/microsoft/vscode/blob/3c257409f43577bc797a94acee32b9213b382958/src/vs/workbench/contrib/terminal/common/terminalEnvironment.ts#L62)
antfu
reviewed
Sep 8, 2025
| return !!(false | ||
| || process.env.VSCODE_PID | ||
| || process.env.VSCODE_CWD | ||
| || process.env.TERM_PROGRAM === "vscode" |
Owner
There was a problem hiding this comment.
I think we should keep the oringal ones and add this as an addotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VSCodium does not set
VSCODE_PIDso it was not detected as a dev environment.The code now checks if there is at least one environment variable starting with "VSCODE_" (there are a few ones on VSCodium)
Linked Issues
Fixes #747
Additional context
I was investigating why my editor was falling into this kind of error: "eslint RangeError: Error while loading rule 'prefer-const': Maximum call stack size exceeded".