feat: turn off prefer-const in editor

antfu · antfu · commit 12dd5b5bd749 · 2025-01-21T22:21:44.000+08:00
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -9,10 +9,6 @@
     "source.organizeImports": "never"
   },
 
-  "eslint.options": {
-    "flags": ["unstable_ts_config"]
-  },
-
   "eslint.runtime": "node",
 
   // Silent the stylistic rules in you IDE, but still auto fix them
diff --git a/README.md b/README.md
@@ -730,7 +730,11 @@ export default antfu({
 
 ### Editor Specific Disables
 
-Some rules are disabled when inside ESLint IDE integrations, namely [`unused-imports/no-unused-imports`](https://www.npmjs.com/package/eslint-plugin-unused-imports) [`test/no-only-tests`](https://github.com/levibuzolic/eslint-plugin-no-only-tests)
+Some rules are disabled when inside ESLint IDE integrations, namely:
+
+- [`prefer-const`](https://eslint.org/docs/rules/prefer-const)
+- [`unused-imports/no-unused-imports`](https://www.npmjs.com/package/eslint-plugin-unused-imports)
+- [`test/no-only-tests`](https://github.com/levibuzolic/eslint-plugin-no-only-tests)
 
 This is to prevent unused imports from getting removed by the IDE during refactoring to get a better developer experience. Those rules will be applied when you run ESLint in the terminal or [Lint Staged](#lint-staged). If you don't want this behavior, you can disable them:
 
diff --git a/src/configs/javascript.ts b/src/configs/javascript.ts
@@ -177,13 +177,15 @@ export async function javascript(
             allowUnboundThis: true,
           },
         ],
-        'prefer-const': [
-          'error',
-          {
-            destructuring: 'all',
-            ignoreReadBeforeAssign: true,
-          },
-        ],
+        'prefer-const': isInEditor
+          ? 'off'
+          : [
+              'error',
+              {
+                destructuring: 'all',
+                ignoreReadBeforeAssign: true,
+              },
+            ],
         'prefer-exponentiation-operator': 'error',
         'prefer-promise-reject-errors': 'error',
         'prefer-regex-literals': ['error', { disallowRedundantWrapping: true }],
diff --git a/src/factory.ts b/src/factory.ts
@@ -33,7 +33,6 @@ import {
   yaml,
 } from './configs'
 import { formatters } from './configs/formatters'
-
 import { regexp } from './configs/regexp'
 import { interopDefault, isInEditorEnv } from './utils'
 
