Skip to content

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Oct 14, 2025

What/Why/How?

Added new OAS 3.2 rules:

rule recommended minimal spec
spec-no-invalid-encoding-combinations error warn error
spec-discriminator-defaultMapping warn off error
spec-example-values error off error

Also, I'm going to deprecate the no-example-value-and-externalValue as the example-values covers its logic and is more versatile.

Fixed a wrong NodeType

https://github.com/Redocly/redocly-cli/pull/2367/files#diff-4a44139d5368084db84e0a7c0e98ae999796c0e03e2dc556dbc136a9ce1c4a0e

Updated docs

Reference

Addresses #2316 (comment)

Related: #2363

Testing

Screenshots (optional)

1

image

2

image image

3

image

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: c399648

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Minor
@redocly/cli Minor
@redocly/respect-core Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.590 ± 0.033 1.549 1.640 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.603 ± 0.030 1.551 1.647 1.01 ± 0.03

@tatomyr tatomyr force-pushed the feat/add-oas3.2-rules branch from 454e1ec to 31d7615 Compare October 14, 2025 15:42
@tatomyr tatomyr changed the title feat: add no-invalid-encoding-combinations OAS 3.2 rule feat: add OAS 3.2 rules Oct 14, 2025
@tatomyr tatomyr force-pushed the feat/add-oas3.2-rules branch from 9f0cd9f to 1774ac5 Compare October 15, 2025 18:57
@tatomyr tatomyr force-pushed the feat/add-oas3.2-rules branch from 1774ac5 to 3d96d21 Compare October 15, 2025 19:03
@tatomyr tatomyr marked this pull request as ready for review October 16, 2025 10:06
@tatomyr tatomyr requested review from a team as code owners October 16, 2025 10:06
examples:
first:
externalValue: "https://example.com/example.json"
externalValue: https://localhost/example.json
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the long running tests issue.

Root ==> Paths --> PathItem --> Operation --> Parameter --> Schema
PathItem --> Parameter
NamedParameter --> Parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, here is missing renaming from NamedParameter -> NamedParameters. This applies to the v1 and v2 docs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks.

@tatomyr tatomyr merged commit 37659e1 into main Oct 16, 2025
38 checks passed
@tatomyr tatomyr deleted the feat/add-oas3.2-rules branch October 16, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants