Skip to content

Conversation

@tatomyr
Copy link
Collaborator

@tatomyr tatomyr commented Oct 10, 2025

What/Why/How?

Fixed an issue where the no-http-verbs-in-paths rule was incorrectly flagging path names containing the verb query.

Reference

Fixes https://redoc-ly.slack.com/archives/C013VB35DB4/p1760032419326879 (internal).

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with Redoc/Realm/Reunite (internal)
  • All new/updated code is covered by tests
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: eada8ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch
@redocly/respect-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tatomyr tatomyr marked this pull request as ready for review October 10, 2025 17:41
@tatomyr tatomyr requested review from a team as code owners October 10, 2025 17:41
@github-actions
Copy link
Contributor

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.460 ± 0.041 1.413 1.559 1.02 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.435 ± 0.010 1.420 1.446 1.00

@tatomyr tatomyr merged commit c363f01 into main Oct 13, 2025
56 of 57 checks passed
@tatomyr tatomyr deleted the fix/no-http-verbs-in-paths branch October 13, 2025 08:24
@jeremyfiel
Copy link
Contributor

any reason you didn't add a check for Root === 3.x and apply the rule according to the spec version? Will you create another rule for 3.2 ?

@tatomyr
Copy link
Collaborator Author

tatomyr commented Oct 24, 2025

@jeremyfiel there's no http verb 'query': https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Methods. It's only a new new operation name in OAS.

@jeremyfiel
Copy link
Contributor

The RFC is just about finished going through the approval process.

https://httpwg.org/http-extensions/draft-ietf-httpbis-safe-method-w-body.html

@tatomyr
Copy link
Collaborator Author

tatomyr commented Oct 24, 2025

Yeah, let's get back to it when it's approved then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants