Added support for WGSL #3455
Added support for WGSL #3455
Conversation
JS File Size Changes (gzipped)A total of 2 files have changed, with a combined diff of +1.49 KB (+55.6%). Details
|
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Thank you for the PR @Dr4gonthree!
The implementation itself looks really good.
However, Prism still supports some older browsers, so we have to remove some newer regexes features like unicode mode and lookbehinds. This is why the lint CI fails.
I also noticed that you often split tokens into multiple patterns. While this is fine, we typically prefer to merge those patterns into one regex (if the resulting regex isn't too complex). We do this because it results in smaller file sizes and because our regex tooling works on a per-regex basis.
Also, some keywords aren't tested.
…ching empty string and '||', '==' and '!=' operator matching
…tr-name. built-in-value alias changed to attr-value
|
Thanks for all the feedback and suggestions @RunDevelopment. |
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
I found some minor things.
CI jobs can be abused to send spam, mine cryptocurrency, or other stuff. To prevent this, not all CI jobs trigger for first-time contributors automatically. A maintainer (e.g. me) has to manually approve that the CI jobs are allowed to run for each commit you make. Unfortunately, this means that the CI may fail long after you make a commit. However, you can run tests ( |
|
Please run |
…ted test cases and rebuild.
|
Thank you for contributing @Dr4gonthree! |
2 participants
This adds support for WGSL, the WebGPU Shading Language.