👷 Add coverage #41
Merged
👷 Add coverage #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds code coverage reporting via Vitest and integrates coverage artifacts into CI and GitHub Pages.
- Configure Vitest to collect and report coverage in multiple formats.
- Update ESLint, Prettier, and workflows to ignore or include the new coverage output.
- Add scripts and dependencies for running coverage locally and in CI.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Setup Vitest coverage includes and reporters |
| tsconfig.eslint.json | Include Vitest config in ESLint type checking |
| package.json | Add test:coverage script and coverage dependencies |
| eslint.config.ts | Remove global ESLint disables and ignore coverage/ |
| .prettierignore | Ignore coverage/ in Prettier |
| .github/workflows/node.js.yaml | Run coverage in CI and upload artifact |
| .github/workflows/github-pages.yaml | Generate coverage in Pages build |
Comments suppressed due to low confidence (2)
vitest.config.ts:8
- Consider adding coverage thresholds (e.g. using watermarks or coverageThreshold in Vitest) to enforce minimum coverage and fail the build if the threshold is not met.
coverage: {
eslint.config.ts:5
- [nitpick] Removing the global eslint-disable for no-unsafe-argument and no-unsafe-member-access might surface new lint errors in this config; consider scoping disables to specific lines or ensuring all calls comply with type safety.
/* eslint-disable @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
I've always wanted to show a coverage badge. This lib has very high coverage, so it should be great to test it there.
main📓 References