Page MenuHomePhabricator
Create Task
Maniphest T366068

Tag deletion logs performed with Nuke
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When we analysed Nuke last year (T341564) we discovered that it is very hard to pull useful data about how, when, and where Nuke is used. We had to take the hacky approach of looking at edit summary texts, including pulling string translations for comparison.

It looks like some other external tools (e.g. Twinkle) use Tags in the deletion log to identify deletions performed with them. We could add a Nuke tag to identify deletions performed by Nuke.

Technical approach:
DeletePageJob allows for adding tags in the constructor. After a little bit of investigation, it looks like it may be that simple:
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Nuke/+/refs/heads/master/includes/SpecialNuke.php#536
https://doc.wikimedia.org/mediawiki-core/master/php/classDeletePageJob.html
https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Page_1_1DeletePage.html

Details

SubjectRepoBranchLines +/-
Tag deletion logs performed with Nukemediawiki/extensions/Nukemaster+18 -4
Customize query in gerrit

Related Objects

Event Timeline

Samwalton9-WMF created this task.May 28 2024, 12:57 PM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 28 2024, 12:57 PM
Samwalton9-WMF mentioned this in T366184: Identify top-level metrics for Nuke.May 29 2024, 2:23 PM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.
KCVelaga_WMF moved this task from Triage to Upcoming Quarter on the Product-Analytics board.May 31 2024, 7:10 AM
Samwalton9-WMF renamed this task from Improve logging & instrumentation for Nuke to Tag deletion logs performed with Nuke.Sep 24 2024, 9:25 AM
Samwalton9-WMF updated the task description. (Show Details)
Samwalton9-WMF mentioned this in T375476: Collect data on how Nuke users filter pages to delete.Sep 24 2024, 9:28 AM
jsn.sherman triaged this task as High priority.Oct 1 2024, 6:45 PM
jsn.sherman updated the task description. (Show Details)
jsn.sherman moved this task from Triaged to To be estimated on the Moderator-Tools-Team board.
jsn.sherman set the point value for this task to 2.Oct 2 2024, 5:41 PM
jsn.sherman moved this task from To be estimated to Up next on the Moderator-Tools-Team board.
jsn.sherman moved this task from Up next to Kanban on the Moderator-Tools-Team board.Oct 15 2024, 4:14 PM
jsn.sherman edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Kgraessle claimed this task.Oct 15 2024, 6:49 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Oct 16 2024, 6:32 PM

Change #1080786 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/Nuke@master] Tag deletion logs performed with Nuke

https://gerrit.wikimedia.org/r/1080786

gerritbot added a project: Patch-For-Review.Oct 16 2024, 6:33 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Oct 17 2024, 2:05 PM
PatchDemoBot added a comment.Oct 22 2024, 3:19 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/ce272af24a/w/

Scardenasmolinar moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Oct 22 2024, 3:30 AM
gerritbot added a comment.Oct 22 2024, 3:38 AM

Change #1080786 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Tag deletion logs performed with Nuke

https://gerrit.wikimedia.org/r/1080786

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.1; 2024-10-29).Oct 22 2024, 4:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 22 2024, 4:30 AM
Samwalton9-WMF added a comment.Oct 22 2024, 4:06 PM

Just tested on Beta, and this looks good!

Screenshot 2024-10-22 at 17.04.41.png (272×1 px, 111 KB)
Samwalton9-WMF added a project: User-notice.Thu, Oct 24, 11:56 AM

Perhaps interesting enough for Tech News:

Deletions performed with the Nuke tool, which allows administrators to mass delete pages, will now be tagged with the 'Nuke' tag, enabling easier review and analysis of deletions performed in this way.

Quiddity moved this task from To Triage to Announce in next Tech/News on the User-notice board.Fri, Oct 25, 8:33 PM
Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.Mon, Oct 28, 7:55 PM
Scardenasmolinar subscribed.

Moving this to Done since it has been QA'ed in Beta. I'll hold on resolving it until we have the announcement in Tech News.

Samwalton9-WMF moved this task from Backlog to Enhancements on the MediaWiki-extensions-Nuke board.Tue, Oct 29, 1:02 PM
UOzurumba moved this task from Announce in next Tech/News to In current Tech/News draft on the User-notice board.Tue, Oct 29, 2:41 PM
UOzurumba moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Wed, Oct 30, 4:31 PM
Scardenasmolinar closed this task as Resolved.Wed, Oct 30, 5:09 PM

We have tested this on test wiki and it is working correctly. Resolving this ticket.

ToBeFree awarded a token.Mon, Nov 4, 1:10 AM
Samwalton9-WMF mentioned this in T379168: Make Nuke tag translatable.Wed, Nov 6, 3:22 PM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Sat, Nov 16, 3:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits