fix(web): prevent reset after complete by call stop() manually #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheRogue76 If you have a time, can you review this PR? It seems valid on me. |
|
I'm not too involved on the web side of things. @arasrezaei you wrote the other PR. Can you provide some context? Does @mym0404 's explanation make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1196, the
stopmethod of inner player was called for preventing reset after animation completion.This seems to is not required and also occur reset frame to
0.this (
_handleAnimationCompletehandler of@dotlottie/react-player) shows the frame should be in last frame at complete automatically ifloopnot set and doesn't callstop()unlessloopconditiontrue.Also,
stopmethod implementation oflottie-webresets frame to zero atstopmethod.So, if we should match the behavior with mobile and web, we should discard this line.