Feat: Circuit for Removing the Quoted Printable Encoding Newlines in Email Body #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
Divide-By-0
reviewed
Jul 13, 2024
| sum_enc[i] <== sum_enc[i - 1] + r_enc[i] * processed[i]; | ||
| } | ||
|
|
||
| // Calculate rlc for decoded |
There was a problem hiding this comment.
Thinking of we need to verify the k characters it got replaced by were zero? Tho I think the random computation should cover but but not sure
There was a problem hiding this comment.
I think the RLC takes care of that
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
had a problem deploying
to
development
GitHub Actions
Failure
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
|
Core circuit looks good to me. Can you make it an argument in the main EmailVerifier component arguments and if on, then apply it to the body string? Also, have you tested it on real emails at all? I'm not convinced they all use \r. |
saleel
reviewed
Jul 25, 2024
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
had a problem deploying
to
development
GitHub Actions
Failure
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
saleel
reviewed
Jul 27, 2024
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
shreyas-londhe
temporarily deployed
to
development
GitHub Actions
Inactive
saleel
approved these changes
Jul 29, 2024
Divide-By-0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a helper circuit which proves the removal of soft line breaks introduced in Quoted Printable Encoding. Aims to resolve #187. Note this does not undo all character encodings, just newlines.
Type of Change
Checklist: